build-recipes: Add --keep-going option #4491
Open
+96
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a --keep-going option to build-recipes that will continue building packages even if some builds fail. As a followup, we should figure out how to stick the failed list somewhere we can easily use to: - revert updates to packages that failed to build - disable packages that failed to build - pin packages that failed to the current version so that auto update ignores them
for more information, see https://pre-commit.ci
hoodmane
commented
Feb 8, 2024
Comment on lines
+214
to
+215
| color = SUCCESS_BLUE if success else FAIL_RED | ||
| print(color + done_message + END_COLOR) |
There was a problem hiding this comment.
Using logger.error here just leaves an empty line on the console. I couldn't figure out how to get it to print correctly. I think this is a reasonable alternative.
There was a problem hiding this comment.
That's very strange. Could you add a comment about it so we can revisit this later?
ryanking13
reviewed
Feb 8, 2024
| @@ -167,6 +167,10 @@ def build_recipes( | |||
| no_deps: bool = typer.Option( | |||
| False, help="Removed, use `pyodide build-recipes-no-deps` instead." | |||
| ), | |||
| keep_going: bool = typer.Option( | |||
There was a problem hiding this comment.
I think this command will not be very useful except for maintainers. So maybe add hidden=True to hide if from the help text?
| ) | ||
| logger.error( | ||
| "Failed to build the following packages: " | ||
| f"[bold]{format_name_list(build_state.failed_list)}[/bold]" |
There was a problem hiding this comment.
why not sort failed and skipped list too?
Comment on lines
+214
to
+215
| color = SUCCESS_BLUE if success else FAIL_RED | ||
| print(color + done_message + END_COLOR) |
There was a problem hiding this comment.
That's very strange. Could you add a comment about it so we can revisit this later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a --keep-going option to build-recipes that will continue building packages even if some builds fail.
I think this will make updating the Python version or a bunch of packages less annoying.
As a followup, we should figure out how to stick the failed list somewhere we can easily use to:
Checklist