Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor timesteppers #1529

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Refactor timesteppers #1529

wants to merge 52 commits into from

Conversation

ftalbrecht
Copy link
Contributor

@ftalbrecht ftalbrecht commented Jan 10, 2022 •
edited

Supersedes #1305, as that pr became unmanageable (see that one for the original motivation). Introduces new timesteppers based on iterators.

  • refactor _step_function to balance performance and usability (original review comments: try to avoid a dynamic definition of the function)
  • delete new-timestepping branch once we are done here

ftschindler and others added 30 commits June 28, 2021 11:31
@ftschindler
[algorithms.timestepping] refactor TimeStepper
8aa2e13 
Instead of solve(), one can now bootstrap() and step() a time stepper.
This allows in particular for incremental state and output computation
(and thus a model based hapod). In addition, temporal interpolation is
improved.
@ftschindler
fix typo
7b13dc0
@ftschindler
[algorithms.timestepping] mass may be parametric
d9ffacc
@ftschindler
[algorithms] add ExplicitRungeKuttaTimeStepper
f781791
@ftschindler
[algorithms.timestepping] refactor to use iterators
d16a21e
@ftschindler
[pymordemos] update model init
56e6be8
@ftschindler
[docs] update use of InstationaryModel
4e36121
@ftschindler
[timestepping] further minor improvements
0993156
@ftschindler
Merge remote-tracking branch 'origin/main' into new-timestepping
a049a2c
@ftalbrecht @sdrave @ftschindler
Update src/pymor/algorithms/timestepping.py
62b0f2a 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftalbrecht @sdrave @ftschindler
Update src/pymor/algorithms/timestepping.py
98e9ae0 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftalbrecht @sdrave @ftschindler
Update src/pymor/algorithms/timestepping.py
3420dee 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftschindler
[discretizers.builtin] fix missing import for 1d visualization
eb27ddd
@ftschindler
[pymortests] add simple timestepping test
919f2dc
@ftschindler
[timestepping] fix timedep check
b0c9428
@ftschindler
[pymordemos] update timestepper usage
c33c2c7
@ftschindler
[docs] update timestepper use in tutorials
16e7ec6
@ftschindler
try to please sphinx by rephrasing doc strings
e49234d
@ftschindler
[algorithms.timestepping] improvements due to code review
bf255e8
@ftschindler
[pymortests] parametrize RK timestepper tests
04d08a9
@ftschindler
rename iter -> return_iter in timesteppers
8476032
@ftschindler
[algorithms.timestepping] fix typo in floatcmp
63fe275
@ftschindler
fix typo fixing
d8c513d
@ftalbrecht @sdrave
Update src/pymor/algorithms/timestepping.py
f36a7a3 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftalbrecht @sdrave
Update src/pymor/algorithms/timestepping.py
3317f5d 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftalbrecht @sdrave
Update src/pymor/algorithms/timestepping.py
8949407 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@ftalbrecht @sdrave
Update src/pymor/algorithms/timestepping.py
875771c 
Co-authored-by: Stephan Rave <stephanrave@uni-muenster.de>
@sdrave
[timestepping] appease my linter
5cd1d5e
@sdrave
[timestepping] remove unneeded IdentityOperator check
1e490ff
@sdrave
[timestepping] use _depends_on_time where needed
bb62132
@ftalbrecht ftalbrecht added pr:new-feature Introduces a new feature pr:change Change in existing functionality labels Jan 10, 2022
@ftalbrecht ftalbrecht added this to the 2022.1 milestone Jan 10, 2022
@ftalbrecht ftalbrecht self-assigned this Jan 10, 2022
@ftalbrecht ftalbrecht mentioned this pull request Jan 10, 2022
Closed
4 tasks
@ftalbrecht
Copy link
Contributor Author

Do I interpret this doc build failure correctly, that some code in a notebook cell takes too long with the new timesteppers for docs to be built?

@ftalbrecht
Copy link
Contributor Author

When building docs, I get warnings of multiple docs regarding num_values. Any recommendations on how to handle this? Is it uncommon to have an init argument with the same name as a property?

@renefritze
Copy link
Member

When building docs, I get warnings of multiple docs regarding num_values. Any recommendations on how to handle this? Is it uncommon to have an init argument with the same name as a property?

As the messages says, you can mark it manually. Or add a suppression in docs/source/autoapipymor.py.
If you have an idea how/where to add this to the dev docs, that would be great.

@ftalbrecht ftalbrecht mentioned this pull request Apr 1, 2022
Closed
@pmli pmli modified the milestones: 2022.1, 2022.2 Jun 7, 2022
@sdrave sdrave mentioned this pull request Jun 7, 2022
Closed
3 tasks
@sdrave sdrave modified the milestones: 2022.2, 2023.1 Nov 28, 2022
@sdrave sdrave force-pushed the main branch 4 times, most recently from 18e66f2 to e80291b Compare March 7, 2023 20:03
@pmli pmli modified the milestones: 2023.1, 2023.2 May 9, 2023
@pmli pmli mentioned this pull request May 18, 2023
Merged
@pmli pmli removed this from the 2023.2 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ftalbrecht ftalbrecht

Labels
pr:change Change in existing functionality pr:new-feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ftalbrecht @renefritze @pmli @sdrave @ftschindler