-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Do not propagate dims to observed component of imputed variable #6263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e435d1
to
6221f89
Compare
df38c8a
to
fca51f0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6263 +/- ##
==========================================
- Coverage 94.19% 88.57% -5.62%
==========================================
Files 102 102
Lines 21477 21480 +3
==========================================
- Hits 20230 19026 -1204
- Misses 1247 2454 +1207
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit of nitpicks about our testing code..
e50cf6d
to
d22a504
Compare
ebcdf0c
to
d22a504
Compare
Uh, it seems tests don't rerun when the PR has already been approved? Had to re-request a review to trigger them |
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
d22a504
to
f196c0e
Compare
Closes #6177
Also did some refactoring and more informative errors for when imputation is not supported
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance