[ruff] Add 'flake8-pathlib' disable the messages that need fixing later #9602
+18
β2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9602 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 173 173
Lines 18833 18833
=======================================
Hits 18046 18046
Misses 787 787
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 9742dee |
DanielNoord
approved these changes
May 7, 2024
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| from contributors_txt import create_contributors_txt | |||
|
|
|||
| CWD = Path(".").absolute() | |||
| CWD = Path().absolute() | |||
There was a problem hiding this comment.
I actually prefer the old version but that might be personal preference.
There was a problem hiding this comment.
Yeah, you have to know the default value so implicit vs explicit. The worst check is the only one autofixxed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
There's some cleanup to do, but we can wait for ruff to autofix most of it. (We need to be careful when performance is a convern i.e. in loops). In the meantime this will make sure that we don't regress on what's already clean.