New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignored modules to Astroid module deny list #9504
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! Will require an astroid release and upgrade that we could do just for this quickly since the value added is huge.
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 90c8723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @Jamie- I rebased your branch on main after we bumped astroid. Would you have a chance to look into the test failure by any chance? Thank you!
And the docs CI check shows an update needed 🙏 |
Type of Changes
Description
Adds ignored modules to the Astroid deny list so they may be truly ignored as they will now not be imported at all.
Depends on Astroid change pylint-dev/astroid#2399
Closes #9442