Fix: [unknown-option-value] False negative after --disable=all #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 302e513 |
jacobtylerwalls
changed the title
Comment on lines
+218
to
+219
| self._runtest([UNNECESSARY_LAMBDA, "--disable=all"], out=out, code=0) | ||
| assert "Your code has been rated at 10.00/10" in out.getvalue().strip() |
There was a problem hiding this comment.
Hi @fellhorn, thanks for picking this up. I think we should find a solution that does not cause this test to fail. If you look at the blame for this line, we're trying to alert the user that they perhaps accidentally disabled all messages. We need to ignore the set of "pylint's own messages" when making that determination so that we can continue to check "accidentally disabled everything but pylint's own messages" if that makes sense.
Pierre-Sassoulas
added
Work in progress
False Negative 🦋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9403 by excluding a set of internal pylint messages from
--disable=all.As this is my first PR to pylint I appreciate any comment on the solution. Especially in regards of the message codes and having to change an existing test.