Recognize new-style attrs decorators in too-few-public-methods check #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning with attrs 21.1.0, the recommended way to use attrs is through `import attrs` and using `attrs.define`/`attrs.frozen`, not `import attr` and `attr.s` or `attr.attrs`. Pylint does understand `attr.attrs` (pylint-dev#2988), but new-style uses of attrs are not understood to be data class decorators. Modify `_is_exempt_from_public_methods` to recognize `attrs.define` and `attrs.frozen` in a similar way as is currently done with `dataclasses.dataclass`. Closes pylint-dev#9345.
Pierre-Sassoulas
added
False Positive π¦
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9346 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18767 18771 +4
=======================================
+ Hits 17981 17985 +4
Misses 786 786
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 86f4378 |
Pierre-Sassoulas
added
Backported
backport maintenance/3.1.x
and removed
backport maintenance/3.1.x
Backported
labels
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2024
β¦9346) Beginning with attrs 21.1.0, the recommended way to use attrs is through `import attrs` and using `attrs.define`/`attrs.frozen`, not `import attr` and `attr.s` or `attr.attrs`. Pylint does understand `attr.attrs` (#2988), but new-style uses of attrs are not understood to be data class decorators. Modify `_is_exempt_from_public_methods` to recognize `attrs.define` and `attrs.frozen` in a similar way as is currently done with `dataclasses.dataclass`. Closes #9345. (cherry picked from commit c032181)
jacobtylerwalls
pushed a commit
that referenced
this pull request
May 4, 2024
β¦9346) (#9596) Beginning with attrs 21.1.0, the recommended way to use attrs is through `import attrs` and using `attrs.define`/`attrs.frozen`, not `import attr` and `attr.s` or `attr.attrs`. Pylint does understand `attr.attrs` (#2988), but new-style uses of attrs are not understood to be data class decorators. Modify `_is_exempt_from_public_methods` to recognize `attrs.define` and `attrs.frozen` in a similar way as is currently done with `dataclasses.dataclass`. Closes #9345. (cherry picked from commit c032181) Co-authored-by: akirchhoff-modular <github-work@kirchhoff.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Beginning with attrs 21.1.0, the recommended way to use attrs is through
import attrsand usingattrs.define/attrs.frozen, notimport attrandattr.sorattr.attrs. Pylint does understandattr.attrs(#2988), but new-style uses of attrs are not understood to be data class decorators.Modify
_is_exempt_from_public_methodsto recognizeattrs.defineandattrs.frozenin a similar way as is currently done withdataclasses.dataclass.Closes #9345