Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linterstats.get_module_message_count() #9146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix linterstats.get_module_message_count() #9146

wants to merge 1 commit into from

Conversation

zasca
Copy link

@zasca zasca commented Oct 12, 2023

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #9145

DanielNoord
DanielNoord reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this behaviour? And perhaps also a news fragment using towncrier?

@jacobtylerwalls jacobtylerwalls added this to the 3.0.2 milestone Oct 13, 2023
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.0.2, 3.0.3 Oct 22, 2023
@jacobtylerwalls jacobtylerwalls added the Waiting on author Indicate that maintainers are waiting for a message of the author label Oct 28, 2023
Pierre-Sassoulas
Pierre-Sassoulas reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zasca do you think you might have time to add automated tests for this ? It would be great if it could go in 3.0.3 :)

@jacobtylerwalls jacobtylerwalls modified the milestones: 3.0.3, 3.0.4 Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This PR needs take over because because it has been open 8 weeks with no activity.

@github-actions github-actions bot added the Needs take over 🛎️ Orignal implementer went away but the code could be salvaged. label Feb 5, 2024
@Pierre-Sassoulas Pierre-Sassoulas removed the Waiting on author Indicate that maintainers are waiting for a message of the author label Feb 5, 2024
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.0.4, 3.1.1 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

@DanielNoord DanielNoord DanielNoord left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs take over 🛎️ Orignal implementer went away but the code could be salvaged.
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

'warnings by module' table missing in a report
4 participants
@zasca @Pierre-Sassoulas @DanielNoord @jacobtylerwalls