Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Protocol as abstract to prevent abstract-method FP #7839

Merged
merged 4 commits into from Nov 30, 2022
Merged

Define Protocol as abstract to prevent abstract-method FP #7839

merged 4 commits into from Nov 30, 2022

Commits on Nov 30, 2022

  1. make protocols be defined as abstract

    @clavedeluna
    clavedeluna committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    a61a828 View commit details
    Browse the repository at this point in the history

  2. add test and rc file

    @clavedeluna
    clavedeluna committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    deaba1a View commit details
    Browse the repository at this point in the history

  3. define Protocol cls as must inherit directly from Protocol

    @clavedeluna
    clavedeluna committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    a74c8bf View commit details
    Browse the repository at this point in the history

  4. add one more test case

    @clavedeluna
    clavedeluna committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    a7b119d View commit details
    Browse the repository at this point in the history