Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the versions of astroid and dill #7838

Merged
merged 3 commits into from Nov 24, 2022
Merged

Upgrade the versions of astroid and dill #7838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
219f2e7
[dill] Use dill 0.3.6 for python 3.11 now that dill released it
Pierre-Sassoulas Nov 23, 2022
c29f96d
Upgrade astroid to 2.12.13
Pierre-Sassoulas Nov 23, 2022
1b9ca43
Fix backport job
Pierre-Sassoulas Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/backport.yml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ on:

permissions:
pull-requests: write
content: write
contents: write

jobs:
backport:
Expand Down
6 changes: 2 additions & 4 deletions pyproject.toml
View file
Open in desktop
Expand Up @@ -33,14 +33,12 @@ classifiers = [
]
requires-python = ">=3.7.2"
dependencies = [
# TODO: Remove dill-pylint once dill 0.3.6 is released
"dill>=0.2;python_version<'3.11'",
"dill-pylint>=0.3.6.dev0;python_version>='3.11'",
"dill>=0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep the >=0.3.6 constraint at least for Python >= 3.11 if lower versions cause problems?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be enforced by pip and dill's metadata automatically.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same but Pierre is right, that shouldn't be our responsibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dill>=0.2",
"dill>=0.2,<1",

Following pyflake's 3.0 release all old releases of autoflake now have broken 2.X typing support. Let's do better for pylint :)
Edit: It's better if I open another issue for this though.

"platformdirs>=2.2.0",
# Also upgrade requirements_test_min.txt.
# Pinned to dev of second minor update to allow editable installs and fix primer issues,
# see https://github.com/PyCQA/astroid/issues/1341
"astroid>=2.12.12,<=2.14.0-dev0",
"astroid>=2.12.13,<=2.14.0-dev0",
"isort>=4.2.5,<6",
"mccabe>=0.6,<0.8",
"tomli>=1.1.0;python_version<'3.11'",
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_min.txt
View file
Open in desktop
@@ -1,6 +1,6 @@
-e .[testutils,spelling]
# astroid dependency is also defined in pyproject.toml
astroid==2.12.12 # Pinned to a specific version for tests
astroid==2.12.13 # Pinned to a specific version for tests
typing-extensions~=4.4
py~=1.11.0
pytest~=7.2
Expand Down