Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge maintenance 2.15.x following the 2.15.5 release #7662

Merged
merged 13 commits into from Oct 22, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 21, 2022

Ref: #7660

danmou and others added 11 commits October 20, 2022 11:28
…values inferred (pylint-dev#7627)

Add a keyword-only `compare_constants` argument to `safe_infer`.
When the dictionary has served its purpose (making plugin loading
pre-and-post init a consistent behaviour), we swap it for bools
indicating whether or not a module was loaded.
We don't currently use the bools, but it seemed a sensible choice.
The main idea is to make the dictionary fully pickle-able, so that when
dill pickles the linter for multiprocessing, it doesn't crash horribly.

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@cdce8p cdce8p added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 21, 2022
@cdce8p cdce8p added this to the 2.15.5 milestone Oct 21, 2022
@coveralls
Copy link

coveralls commented Oct 21, 2022

Pull Request Test Coverage Report for Build 3300574766

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.349%

Totals Coverage Status
Change from base Build 3297353600: 0.0%
Covered Lines: 17138
Relevant Lines: 17974

💛 - Coveralls

@cdce8p cdce8p mentioned this pull request Oct 21, 2022
Comment on lines +264 to +267
"dmrtzn@gmail.com": {
"mails": ["dmrtzn@gmail.com"],
"name": "Daniel Mouritzen"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it required (=crash of contributor-txt) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I added it when I was trying to understand what contrbutor-txt was doing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not bother removing it, this contributor might use another email later.

@Pierre-Sassoulas Pierre-Sassoulas merged commit a0b7719 into pylint-dev:main Oct 22, 2022
@cdce8p cdce8p deleted the merge-maintenance-2.15.5 branch October 22, 2022 10:32
@Pierre-Sassoulas
Copy link
Member

Congrats on your first release @cdce8p !!

@cdce8p
Copy link
Member Author

cdce8p commented Oct 22, 2022

Congrats on your first release @cdce8p !!

Thanks 😄 You all did an amazing work laying the foundation to make the process easier. The fact that it took me only a day to get up to speed is awesome. Even if we can still improve some smaller things 😉

I'll still leave the minor release to you for the time being though.
Maybe I'll do another patch release sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants