In "Messages Overview", show the bad_code first
#7162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes more sense to _first define the problem_, then solve it. Mentions issue pylint-dev#7143 Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Pierre-Sassoulas
added
Enhancement ✨
Pierre-Sassoulas
approved these changes
Jul 11, 2022
|
I can't modify your branch, could you apply the suggestion please ? :) |
Roll back the news snippet; it's not needed Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pull Request Test Coverage Report for Build 2650629272
💛 - Coveralls |
|
Congratulation on your first contribution to pylint 😉 |
|
Wo-hoooo 🎉 🎉 🎉 🎉 🎉 |
stdedos
added a commit
to stdedos/pylint
that referenced
this pull request
Feb 22, 2023
In pylint-dev#7162, "we decreed" that the `bad_code` goes first, then the `good_code`. Fixup current changes, to revert "back to standards". Additionally, tackle the comment here pylint-dev#8287 (comment) "Message emitted" is technically still code (`%-formatting`); let us make it stand out properly. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 22, 2023
In #7162, "we decreed" that the `bad_code` goes first, then the `good_code`. Fixup current changes, to revert "back to standards". Additionally, tackle the comment here #8287 (comment) "Message emitted" is technically still code (`%-formatting`); let us make it stand out properly. Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to first define the problem, then solve it.
Mentions issue #7143
Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com
Type of Changes
Description
Refs #7143