Bump or remove some TODOs
#7141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
Pierre-Sassoulas
requested changes
Jul 7, 2022
There was a problem hiding this comment.
The last two todos will be done in #6974 and related merge request.
| @@ -219,8 +219,6 @@ def visit_instance(self, instance: objects.ExceptionInstance) -> None: | |||
| visit_exceptioninstance = visit_instance | |||
|
|
|||
| def visit_classdef(self, node: nodes.ClassDef) -> None: | |||
There was a problem hiding this comment.
Something needs to be done here, unless instance._proxied always return a nodes.ClassDef. But I think at least Instance is a possibility.
There was a problem hiding this comment.
No, I recently fixed the typing here. _proxied is always ClassDef.
Will be available in 2.12
Pierre-Sassoulas
approved these changes
Jul 7, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 1132063 |
Pull Request Test Coverage Report for Build 2628072019
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
@Pierre-Sassoulas only two TODOs remain. Could you take a look at those:
https://github.com/PyCQA/pylint/blob/7616e83e2541a5f3a66ea2caa751979c0f398d2b/script/bump_changelog.py#L19
https://github.com/PyCQA/pylint/blob/7616e83e2541a5f3a66ea2caa751979c0f398d2b/script/fix_documentation.py#L17
Refs. #6632.