Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hangs on many-core Windows machines #7035

Merged
merged 8 commits into from Jun 25, 2022
Merged

Avoid hangs on many-core Windows machines #7035

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ba5867
Avoid Win32 multiprocessing limits
randomascii Jun 24, 2022
a8b2ad8
Add note to index.rst
randomascii Jun 24, 2022
75b2d6c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 24, 2022
252fc65
Merging with head
randomascii Jun 24, 2022
a47759d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 24, 2022
99f24c0
Doc changes and comment change
randomascii Jun 24, 2022
3d19c0d
Move changelog
DanielNoord Jun 25, 2022
7c709da
Add coverage pragma
DanielNoord Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/2/2.15/index.rst
View file
Open in desktop
Expand Up @@ -94,3 +94,6 @@ Internal changes
let the functional test fail with a default value.

Refs #6891

* Fixed an issue where many-core Windows machines (>~60 logical processors) would hang when
using the default jobs count.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to backport that in 2.14.4 :)

5 changes: 5 additions & 0 deletions pylint/lint/run.py
View file
Open in desktop
Expand Up @@ -190,6 +190,11 @@ def __init__(
linter.set_option("jobs", 1)
elif linter.config.jobs == 0:
linter.config.jobs = _cpu_count()
if sys.platform == "win32":
randomascii marked this conversation as resolved.
Show resolved Hide resolved
# Using too many child processes in Python 3 hits either hangs or a
# ValueError exception, and, has diminishing returns. Clamp to 56 to
# give margin for error.
min(jobs, 56)

if self._output:
try:
Expand Down