Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for successful instead of completed runs on main for primer #6945

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Fixes run failures such as those seen in #6898.

Because skipped runs are also counted as completed we don't get the correct run whenever an initial run on main is skipped but the new one hasn't yet finished. See https://docs.github.com/en/rest/actions/workflow-runs#list-workflow-runs

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this was annoying πŸ˜„

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 558ddf9

@Pierre-Sassoulas Pierre-Sassoulas merged commit b524db8 into pylint-dev:main Jun 13, 2022
@DanielNoord DanielNoord deleted the primer-status branch June 13, 2022 16:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2489225865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.541%

Totals Coverage Status
Change from base Build 2489123584: 0.0%
Covered Lines: 16412
Relevant Lines: 17178

πŸ’› - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants