Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exception for IndexError inside uninferable_final_decorator #6532

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog
Expand Up @@ -307,6 +307,9 @@ What's New in Pylint 2.13.9?
============================
Release date: TBA

* Fix ``IndexError`` crash in ``uninferable_final_decorators`` method.

Relates to #6531


What's New in Pylint 2.13.8?
Expand Down
4 changes: 4 additions & 0 deletions doc/whatsnew/2.13.rst
Expand Up @@ -639,3 +639,7 @@ Other Changes
``open``

Closes #6414

* Fix ``IndexError`` crash in ``uninferable_final_decorators`` method.

Relates to #6531
2 changes: 1 addition & 1 deletion pylint/checkers/utils.py
Expand Up @@ -850,7 +850,7 @@ def uninferable_final_decorators(
if isinstance(decorator, nodes.Attribute):
try:
import_node = decorator.expr.lookup(decorator.expr.name)[1][0]
except AttributeError:
except (AttributeError, IndexError):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should distinguish the two errors and try to handle the case where we can't do [1][0]. I guess Daniel will have an opinion :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the logic is simpler now with 38cbeeb & it more closely matches the nodes.Name case beneath it in the same function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, need to re-add the try-except since the primer test fails without it.

continue
elif isinstance(decorator, nodes.Name):
lookup_values = decorator.lookup(decorator.name)
Expand Down
28 changes: 28 additions & 0 deletions tests/functional/r/regression/regression_6531_crash_index_error.py
@@ -0,0 +1,28 @@
# pylint: disable=missing-docstring, redefined-outer-name
mbyrnepr2 marked this conversation as resolved.
Show resolved Hide resolved

import pytest


class Wallet:
def __init__(self):
self.balance = 0

def add_cash(self, earned):
self.balance += earned

def spend_cash(self, spent):
self.balance -= spent

@pytest.fixture
def my_wallet():
'''Returns a Wallet instance with a zero balance'''
return Wallet()

@pytest.mark.parametrize("earned,spent,expected", [
(30, 10, 20),
(20, 2, 18),
])
def test_transactions(my_wallet, earned, spent, expected):
my_wallet.add_cash(earned)
my_wallet.spend_cash(spent)
assert my_wallet.balance == expected