Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release branch 2.14 beta #6527

Merged
merged 1 commit into from
May 10, 2022
Merged

Release branch 2.14 beta #6527

merged 1 commit into from
May 10, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 📜 Docs

Description

Closes #6062

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label May 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone May 6, 2022
@Pierre-Sassoulas
Copy link
Member Author

Sorry I know the review is hardcore but I don't think there's an easy way to move the deprecation in the changelog with a nice diff. The change in example pylintrc are automated.

DanielNoord
DanielNoord requested changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also request a review from @jacobtylerwalls, he trumps both of us in terms of spelling and English 😄

examples/pylintrc Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst
private API and most methods that were public on ``OptionsProviderMixIn`` have now been deprecated and will
be removed in a future release.

Ref #5392
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is horrible, but I'm just going to assume you copied these correctly 😄

@coveralls
Copy link

coveralls commented May 6, 2022 •
edited

Pull Request Test Coverage Report for Build 2299921384

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.326%
Totals Coverage Status
Change from base Build 2299779098: 0.0%
Covered Lines: 16029
Relevant Lines: 16815
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label May 6, 2022
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 6, 2022
Merged
jacobtylerwalls
jacobtylerwalls reviewed May 6, 2022
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! 🎉

doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member Author

Blocked by #6529

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 6, 2022
Closed
@cdce8p
Copy link
Member

cdce8p commented May 7, 2022 •
edited

I would like to include a fix for #6523 / #4369 in 2.14.0 if it's not too late. Working on it now, should be ready in ~30min.

@DanielNoord
Copy link
Collaborator

I probably won't be able to get to the open issues with argparse until tomorrow/monday. So no rush!

@DanielNoord
Copy link
Collaborator

DanielNoord commented May 10, 2022 •
edited

I have one last blocker PR which should be good to go in a couple of minutes.

Edit: Opened #6569.

Edit2: No longer blocked 🎉

@DanielNoord DanielNoord removed the Blocked 🚧 Blocked by a particular issue label May 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 10, 2022
Closed
15 tasks
DanielNoord
DanielNoord reviewed May 10, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, shouldn't tbump update the config examples to now also use MAIN?

doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member Author

Hmm nice catch I just rebased without relaunching tbump. Let me fix that

@Pierre-Sassoulas
Bump pylint to 2.14.0-b0, update changelog
b5aad5f 
Update contributors and create release summary
DanielNoord
DanielNoord approved these changes May 10, 2022
View reviewed changes
requirements_test.txt
@@ -10,3 +10,4 @@ pytest-profiling~=1.7
pytest-xdist~=2.5
# Type packages for mypy
types-pkg_resources==0.1.3
tox>=3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need that for tbump (upgrading the doc)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to install it only in tbump, as it's going to slow down every pipelines for no good reason though. But we also suggest using tox in the doc...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Well, I think this is fine. Most people will install it anyway at some point.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2dfff17 into pylint-dev:main May 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-2.14 branch May 10, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

(❓) Should minor versions have pre-releases
5 participants
@Pierre-Sassoulas @coveralls @cdce8p @DanielNoord @jacobtylerwalls