Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash in the unsupported-membership-test checker involving tuple unpacking #6367

Merged
merged 6 commits into from Apr 19, 2022
Merged

Fix a crash in the unsupported-membership-test checker involving tuple unpacking #6367

merged 6 commits into from Apr 19, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

An assumption of direct parentage between AssignName and Assign was violated by tuple unpacking.

Closes #6366

@jacobtylerwalls
Fix a crash in the unsupported-membership-test checker
4284133 
An assumption of direct parentage between `AssignName` and `Assign` was violated by tuple unpacking.
@jacobtylerwalls jacobtylerwalls added the Crash 💥 A bug that makes pylint crash label Apr 17, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.13.6 milestone Apr 17, 2022
@jacobtylerwalls jacobtylerwalls added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Apr 17, 2022
@coveralls
Copy link

coveralls commented Apr 17, 2022 •
edited

Pull Request Test Coverage Report for Build 2190814920

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.167%
Totals Coverage Status
Change from base Build 2190638605: 0.001%
Covered Lines: 15791
Relevant Lines: 16593
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 43f9a11 into pylint-dev:main Apr 19, 2022
@jacobtylerwalls jacobtylerwalls deleted the tuple-assign-iter branch April 19, 2022 18:03
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Apr 20, 2022
Pierre-Sassoulas pushed a commit that referenced this pull request Apr 20, 2022
@jacobtylerwalls @Pierre-Sassoulas
Fix a crash in the unsupported-membership-test checker involving …
7231dd5 
…tuple unpacking (#6367)

An assumption of direct parentage between `AssignName` and `Assign` was violated by tuple unpacking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported Crash 💥 A bug that makes pylint crash
Projects
None yet
Milestone
2.13.6
Development

Successfully merging this pull request may close these issues.

AttributeError: 'ClassDef' object has no attribute 'value'
4 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord