Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music21 and remove graph-explorer from primer #6272

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

See #6049 (comment).

The other package got its last commit in 2015 and hasn't updated its pylintrc. This will become problematic and we should probably exclude it. Open to any other suggestions for now packages!

@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 11, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2151386237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.69%

Totals Coverage Status
Change from base Build 2151105524: 0.0%
Covered Lines: 15888
Relevant Lines: 16958

πŸ’› - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, removing dead project is a good thing !

@DanielNoord DanielNoord merged commit 95b628e into pylint-dev:main Apr 11, 2022
@DanielNoord DanielNoord deleted the music branch April 11, 2022 22:19
@jacobtylerwalls jacobtylerwalls removed their request for review April 12, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants