Fix crash in use-maxsplit-arg checker where sep given by keyword
#5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1799723267
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Feb 5, 2022
DanielNoord
approved these changes
Feb 5, 2022
|
Ah, we did get a report! I linked #5737 |
|
Yeah I meant earlier, as in with issue number 1000 or something. This seems like a very basic and possible common python pattern. |
This is because it's a new checker in 2.9 #4469 (so we were at least over 4600 issues when it was released). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix crash in
use-maxsplit-argchecker ifsepis provided by keyword tostr.split().Closes #5737