Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to checker and plugin attributes of PyLinter #5574

Merged
merged 1 commit into from Dec 21, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
🔨 Refactoring

Description

Seems like we made an error in #5004 that I didn't catch in my review.

Checkers __implements__ Ichecker, but this isn't picked up on by mypy. The typing should thus be BaseChecker.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 21, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1606600609

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.691%

Totals Coverage Status
Change from base Build 1605912068: 0.0%
Covered Lines: 14300
Relevant Lines: 15263

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've already done that in #5558 😄 ? (Well I used an union of both sometime)

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Dec 21, 2021
@DanielNoord
Copy link
Collaborator Author

I didn't check that, but if you did we should remove IChecker. mypy has no way to interact with it so it doesn't really provide us with much..

@Pierre-Sassoulas
Copy link
Member

@DanielNoord
Copy link
Collaborator Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants