Fix used-before-assignment for conditional self-referential typing
#5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
False Positive 🦟
| @@ -1805,7 +1805,7 @@ def _is_first_level_self_reference( | |||
| """ | |||
| if ( | |||
| node.frame().parent == defstmt | |||
| and node.statement(future=True) not in node.frame().body | |||
| and node.statement(future=True) == node.frame() | |||
There was a problem hiding this comment.
I don't understand how this work, could you explain ?
There was a problem hiding this comment.
Basically for arguments in function definitions their statement is also their frame (the function definition). For nodes within the body or even within sub-bodies (conditionals) the statement will be different from the frame (the latter still being the function definition).
There was a problem hiding this comment.
That makes sense, thank you.
Pull Request Test Coverage Report for Build 1584679706
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Closes #5499.
I should have thought of this fix in #5342. This is much better..