Fix used-before-assignment for assignment expressions in lambda
#5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
False Positive 🦟
Pull Request Test Coverage Report for Build 1606114780
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Dec 15, 2021
DanielNoord
added
the
C: used-before-assignment
|
Also closes #3877. Adding it to the list of closed issues. |
DanielNoord
commented
Dec 16, 2021
|
Do you want another review before merging ? |
|
I think this should be fine. We have two separate issues reports about this and this fixes this issue. I don't think this was an intended message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
This closes #5360, closes #3877
See a prior discussion in #5241 (comment) and @jacobtylerwalls's comments about it #5241 (comment).
This also fixes the message that gets raised in
home-assistanthttps://github.com/home-assistant/core/blob/296b73874054eec31d91f0db1b9a625ad5d47c32/homeassistant/components/sht31/sensor.py#L63. That also seems to indicate to me that this code is not doing anything meaningful.The original commit that added it was 5193b7d.
The tests added in that commit still pass with the change in this PR so I think this should be fine?