Fix _regexp_paths_csv_validator for already validated values
#5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
force-pushed
the
regexp-paths-validator
branch
from
904e9bd
to
4a175d3
Compare
Pull Request Test Coverage Report for Build 1517860490
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
The fix is so elegant that I don't know why it works 😄 Why are we encountering already validated value ? The option parsing code is messed up and the problem will disappear when we move to something else in #5392 ?
| @@ -27,7 +27,11 @@ def _regexp_csv_validator(_, name, value): | |||
| return [_regexp_validator(_, name, val) for val in _csv_validator(_, name, value)] | |||
|
|
|||
|
|
|||
| def _regexp_paths_csv_validator(_, name: str, value: str) -> List[Pattern[str]]: | |||
| def _regexp_paths_csv_validator( | |||
| _, name: str, value: Union[str, List[Pattern[str]]] | |||
It has something to do with: Both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Closes #5437
I have not done anything to the error. The error is actually based on a pattern we have made, but should never be encountered by users. Since this is also related to
optparseI don't think it is worth the effort to improve the error code and handling of it for now.