Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consider-interating-dictionary): fix false negatives #5331

Merged
merged 8 commits into from
Nov 30, 2021
Merged

fix(consider-interating-dictionary): fix false negatives #5331

merged 8 commits into from
Nov 30, 2021

Commits on Nov 28, 2021

  1. fix(consider-interating-dictionary): fix false negatives

    @yushao2
    yushao2 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    be257fe View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
    @yushao2 @DanielNoord @Pierre-Sassoulas
    3 people committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    2b3ed7e View commit details
    Browse the repository at this point in the history

  3. added util functions and changed code according to pr comments

    @yushao2
    yushao2 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    554801a View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
    @yushao2 @DanielNoord
    yushao2 and DanielNoord committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    ccd2974 View commit details
    Browse the repository at this point in the history

  5. update code based on code review

    @yushao2
    yushao2 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    507c502 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @yushao2
    pre-commit-ci[bot] authored and yushao2 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    0ec1975 View commit details
    Browse the repository at this point in the history

  7. Update pylint/checkers/refactoring/recommendation_checker.py 

    Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
    @yushao2 @DanielNoord
    yushao2 and DanielNoord committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    39fb9eb View commit details
    Browse the repository at this point in the history

  8. chore(*): moved changelog entry from 2.12 to 2.13

    @yushao2
    yushao2 committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    03bae75 View commit details
    Browse the repository at this point in the history