Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect consider-using-ternary when condition is inferable as False #5227

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Fix incorrect consider-using-ternary when condition is inferable as False #5227

merged 3 commits into from
Oct 29, 2021

Commits on Oct 28, 2021

  1. Fix incorrect consider-using-ternary when condition is inferrable… 

    … as False

* Properly infer the condition in old ternary statements and suggest ``simplify-boolean-expression`` over ``consider-using-ternary`` if it is False

* Integration test for this behavior
    @areveny
    areveny committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    9bcdf07 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Refactor logic to null check more explicitly and avoid a mypy error

    @areveny
    areveny committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    99b0de6 View commit details
    Browse the repository at this point in the history

  2. Make documentation more concise

    @areveny
    areveny committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    6891588 View commit details
    Browse the repository at this point in the history