New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to filepath
#4980
Merged
Pierre-Sassoulas
merged 21 commits into
pylint-dev:main
from
DanielNoord:typing-filepath
Sep 16, 2021
Merged
Add typing to filepath
#4980
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
dc3696f
Add typing to ``filepath``
DanielNoord 56b1061
Change tests for ``filepath`` changes
DanielNoord 565e245
Code review
DanielNoord 2b46031
Additional code review
DanielNoord a680a4a
Merge branch 'main' into typing-filepath
DanielNoord 7bd3810
Update pylint/lint/parallel.py
DanielNoord f4a7045
Add pylint/typing.py and FileItem NamedTuple
DanielNoord 6af1902
Code review
DanielNoord ccaaa86
Apply suggestions from code review
DanielNoord 4c31342
Use NamedTuple more efficiently
DanielNoord 4859288
Merge branch 'main' of https://github.com/PyCQA/pylint into pyannotat…
DanielNoord b8ba102
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 096f8a8
Merge branch 'typing-filepath-tests' of https://github.com/DanielNoor…
DanielNoord 0910978
Fix tests and errors
DanielNoord dd67951
Update pylint/lint/pylinter.py
DanielNoord 32742d2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cfc01da
Fix errors and tests after adding warning
DanielNoord 21e6f76
Code review
DanielNoord 4df05c5
Fix tests
DanielNoord 58d0e88
Revert docstring change
DanielNoord 0cf4b1f
Apply suggestions from code review
DanielNoord File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mpy
complains on the following two lines about the possibility that_work_linter
might beNone
.We currently already test for this, but do so with catching an
AttributeError
on L73. See:https://github.com/PyCQA/pylint/blob/fab2de272b3fc36dc4480d89840b8bfe0fbfbd0c/tests/test_check_parallel.py#L177-L182
I think making this error more explicit as
mypy
wants makes sense. Although this is probably the wrongException
type.