Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved consider-using-f-string to RecommendationChecker #4957

Merged
merged 2 commits into from Sep 3, 2021
Merged

Moved consider-using-f-string to RecommendationChecker #4957

merged 2 commits into from Sep 3, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Based on discussion in #4787

Should this have a changelog entry?

@coveralls
Copy link

coveralls commented Sep 3, 2021 •
edited

Pull Request Test Coverage Report for Build 1197890661

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.099%
Totals Coverage Status
Change from base Build 1197864226: 0.001%
Covered Lines: 13235
Relevant Lines: 14216
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 3, 2021
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 3, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 6c81831 into pylint-dev:main Sep 3, 2021
@DanielNoord DanielNoord deleted the move-consider-f branch September 8, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas