Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for function-redefined for simple type annotations #4938

Merged
merged 1 commit into from Aug 31, 2021
Merged

Fix false positive for function-redefined for simple type annotations #4938

merged 1 commit into from Aug 31, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Fix false positive for function-redefined for simple type annotations.
Closes #4936

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a clean fix !

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Aug 31, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 8b778cd into pylint-dev:main Aug 31, 2021
@DanielNoord DanielNoord deleted the function-redefined-patch branch August 31, 2021 10:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1185597514

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.784%
Totals Coverage Status
Change from base Build 1185118087: 0.0%
Covered Lines: 13566
Relevant Lines: 14621
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug 🪲
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

function-redefined false positive with type hints
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas