pyreverse: Add option for colored output
#4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudeNr33
commented
Aug 15, 2021
DudeNr33
commented
Aug 15, 2021
DudeNr33
commented
Aug 15, 2021
tests/pyreverse/test_writer.py
Outdated
| obj = Mock() | ||
| obj.node = Mock() | ||
| obj.node.qname.return_value = "collections" | ||
| assert writer.get_color(obj) == "grey" |
There was a problem hiding this comment.
I hope this test works well in the CI.
On my local computer it passes in the tox environment, but fails when running the test directly from VS code. I guess it has something to do with the way the virtual environment is set up.
If it causes issues we can remove this test, I only included it because otherwise the corresponding could would have no test coverage. But given that the code is simple, having a more stable CI (and dev environments for other contributors) might be more important.
There was a problem hiding this comment.
It seems it's passing so probably something due to your VScode environment ? I don't see how this test could be flaky.
Pull Request Test Coverage Report for Build 1133158792
💛 - Coveralls |
Pierre-Sassoulas
added
Enhancement ✨
Pierre-Sassoulas
approved these changes
Aug 15, 2021
3 tasks
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
This MR adds two command line options to
pyreverse:--colorized: Use colored output. Classes/modules of the same package get the same color.--max-color-depth: Use separate colors up to package depth ofThis feature is usable with
DotPrinterandPlantUmlPrinter.VCGPrinterwill simply ignore the color passed to it.Closes #4488