Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure --fail-on always returns a non-zero exit code when issue is matched #4713

Merged
merged 6 commits into from
Jul 17, 2021
Merged

Ensure --fail-on always returns a non-zero exit code when issue is matched #4713

merged 6 commits into from
Jul 17, 2021

Commits on Jul 15, 2021

  1. Changed exit logic.

    @MarkCBell
    MarkCBell committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    ffd8132 View commit details
    Browse the repository at this point in the history

  2. Described change in Changelog.

    @MarkCBell
    MarkCBell committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c4ab928 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Added unit tests and allow fail-under to apply even when the score is… 

    … exactly zero.
    @MarkCBell
    MarkCBell committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    ea03163 View commit details
    Browse the repository at this point in the history

  2. Linted and re-added None check of score.

    @MarkCBell
    MarkCBell committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    4351b6d View commit details
    Browse the repository at this point in the history

  3. Update ChangeLog 

    Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
    @MarkCBell @Pierre-Sassoulas
    MarkCBell and Pierre-Sassoulas committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    c586f6c View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    b750b8b View commit details
    Browse the repository at this point in the history