Fix false-positive consider-using-with
for ternary conditionals in with
items
#4679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>
.Description
For details see #4676 - things like
open
calls inside ternary conditionals used in awith
were incorrectly flagged with theconsider-using-with
, because the check if this call happens inside the items of awith
only looked at the first parent node.This is now expanded to check all parents until we reach the enclosing frame.
I also ran
pylint
over a few other codebases (black, requests, pip, twine) and (luckily 😁) found no new edge cases.But I somehow have a feeling that this won't stay the last fix of false-positives for
consider-using-with
...Type of Changes
Related Issue
Closes #4676