Remove type check from arguments-differ #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
May 10, 2021
ksaketou
added a commit
to ksaketou/pylint
that referenced
this pull request
May 11, 2021
This commits creates the new error arguments-renamed based on the functionality added on pylint-dev#4422 and the changes of pylint-dev#4456.
4 tasks
Pierre-Sassoulas
added a commit
that referenced
this pull request
May 17, 2021
* Create new error arguments-renamed This commits creates the new error arguments-renamed based on the functionality added on #4422 and the changes of #4456. * Merge test files for arguments-differ This commit merges the two kinds of test files that existed for the arguments-differ error, since now all tests run in Python3. * Add tests for arguments-renamed error * Add new error arguments-renamed Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert part of #4422 to fix crash when checking function overwrites for
arguments-differ.pylintisn't well suited to check type annotations. That's what type checkers likemypyare for which already implement such a check: https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides/CC: @Pierre-Sassoulas @ksaketou
Type of Changes
Related Issue
Closes #4443