Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog #4442

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix changelog #4442

merged 1 commit into from
May 10, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 6, 2021

Type of Changes

Type
✓ 📜 Docs

Related Issue

#4422

Pierre-Sassoulas
Pierre-Sassoulas reviewed May 6, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we change that for releasing often and not bothering having a bug fixing branch ? I know only you and hippo participated to the discussion, but we're also the one doing the actual release work.

@cdce8p
Copy link
Member Author

cdce8p commented May 6, 2021

Didn't we change that for releasing often and not bothering having a bug fixing branch ? I know only you and hippo participated to the discussion, but we're also the one doing the actual release work.

AFAIK we didn't reached a final conclusion yet. The main issue here is that the entry should belong to 2.9.0 instead of the already released 2.8.1.

Btw, don't know why the tests are failing all of the sudden.

@Pierre-Sassoulas
Copy link
Member

The release.md was modified in #4263.

Yeap, it's strange, the latest commit on master passed.

@cdce8p
Copy link
Member Author

cdce8p commented May 6, 2021

Yeap, it's strange, the latest commit on master passed.

I managed to narrow it down a bit. It seems like the last Python update caused it (3.8.10 and 3.9.5). I just checked 3.9.4 and the tests pass. Just from the changelog I would guess it's this change although I haven't read it yet: https://bugs.python.org/issue43105

We probably need to update our tests then 🤷🏻‍♂️

@coveralls
Copy link

coveralls commented May 7, 2021 •
edited

Coverage Status

Coverage remained the same at 91.699% when pulling 436fb5f on cdce8p:changelog into f9df028 on PyCQA:master.

cdce8p
cdce8p commented May 7, 2021
View reviewed changes
ChangeLog Outdated
Comment on lines 16 to 18
What's New in Pylint 2.8.3?
===========================
Release date: TBA
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Sassoulas Should I remove the 2.8.3 section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to release a 2.8.3 next. It depends on how long the blocker takes ?

@cdce8p cdce8p mentioned this pull request May 7, 2021
Merged
4 tasks
@cdce8p cdce8p merged commit 519e31e into pylint-dev:master May 10, 2021
@cdce8p cdce8p deleted the changelog branch May 10, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdce8p @Pierre-Sassoulas @coveralls