Keep __pkginfo__.numversion a tuple #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids breaking pylint-django
Pierre-Sassoulas
requested changes
Apr 26, 2021
|
Downstream would make sense too (using importlib metadata is more solid I think). I'd like to get rid of this in pylint 3.0 because I want to automate version with scm_setuptool and simplify everything. (but I guess we could also add something to get the automated version in pylint). |
@Pierre-Sassoulas like this? dfbeca9 |
Pierre-Sassoulas
approved these changes
Apr 26, 2021
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After 2.8.1
__pkginfo__.numversionwas now a list which broke pylint-django. See #4405This avoids breaking pylint-django like described here pylint-dev/pylint-django#323
Not sure if it would make sense to fix here or downstream
Type of Changes
Related Issue
Closes #4405