Remove 2.8.0 breaking changes in __pkginfo__
#4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
changed the title
__pkginfo__
Pierre-Sassoulas
force-pushed
the
breaking-change-in-packaging
branch
from
f5eb153
to
c768e31
Compare
Pierre-Sassoulas
force-pushed
the
breaking-change-in-packaging
branch
from
c768e31
to
fc21e3b
Compare
Pierre-Sassoulas
changed the title
__pkginfo____pkginfo__
cdce8p
approved these changes
Apr 25, 2021
michael-k
reviewed
Apr 26, 2021
Comment on lines
+18
to
+19
| # Kept for compatibility reason, see https://github.com/PyCQA/pylint/issues/4399 | ||
| numversion = __version__.split(".") |
There was a problem hiding this comment.
In <2.8 is was a tuple, not a list, see fbcb27a#diff-42df8bb8e2d7b0a18f0174dcb5f3c60b1cbca5a394c3c7f8c9b33c99fb6cda99L34
list causes the following TypeError in pylint-django (pylint-dev/pylint-django#323)
LOAD_CONFIGURATION_SUPPORTED = pylint.__pkginfo__.numversion >= (2, 3)
TypeError: '>=' not supported between instances of 'list' and 'tuple'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem in the code given in the changelog, and we needed it in a more visible section in What's new
Related Issue
Closes #4399