Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix build for setuptools 50.0.0 #3806

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Aug 31, 2020

Not having this option is creating an error:

   SystemError: Parent module 'setuptools' not loaded,
   cannot perform relative import

See https://travis-ci.org/github/PyCQA/pylint/jobs/722843170:

It isn't clear what a permanent fix could be. See
pypa/setuptools#2232 and
https://github.com/pypa/setuptools/blob/17cb9d6bf249cefe653d3bdb712582409035a7db/CHANGES.rst#v5000
for details.

Type of Changes

Type
🐛 Bug fix

Not having this option is creating an error:
   SystemError: Parent module 'setuptools' not loaded,
   cannot perform relative import

See https://travis-ci.org/github/PyCQA/pylint/jobs/722843170:

It isn't clear what a permanent fix could be. See
pypa/setuptools#2232 and
https://github.com/pypa/setuptools/blob/17cb9d6bf249cefe653d3bdb712582409035a7db/CHANGES.rst#v5000
for details.
@coveralls
Copy link

coveralls commented Aug 31, 2020

Coverage Status

Coverage remained the same at 90.726% when pulling 099645a on Pierre-Sassoulas:fix-setuptools-not-loaded into 5b68441 on PyCQA:master.

@Pierre-Sassoulas
Copy link
Member Author

It looks like removing virtualenv to keep the builtin "venv" could work. I'll investigate after hotfixing.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2261844 into pylint-dev:master Aug 31, 2020
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-setuptools-not-loaded branch September 23, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants