Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing special method names #3282

Merged
merged 3 commits into from Dec 2, 2019
Merged

Add missing special method names #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f653701
Remove duplicates.
MatthijsBlom Nov 30, 2019
25a90fe
Add missing special method names.
MatthijsBlom Nov 30, 2019
d6d007c
Document contribution.
MatthijsBlom Nov 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Expand Up @@ -354,3 +354,5 @@ contributors:
* Pek Chhan: contributor

* Craig Henriques: contributor

* Matthijs Blom: contributor
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Expand Up @@ -7,6 +7,10 @@ What's New in Pylint 2.5.0?

Release date: TBA

* `__pow__`, `__imatmul__`, `__trunc__`, `__floor__`, and `__ceil__` are recognized as special method names.

Close #3281

* Added errors for protocol functions when invalid return types are detected.
E0304 (invalid-bool-returned): __bool__ did not return a bool
E0305 (invalid-index-returned): __index__ did not return an integer
Expand Down
11 changes: 5 additions & 6 deletions pylint/checkers/utils.py
View file
Open in desktop
Expand Up @@ -100,13 +100,10 @@
"__complex__",
"__int__",
"__float__",
"__neg__",
"__pos__",
"__abs__",
"__complex__",
"__int__",
"__float__",
"__index__",
"__trunc__",
"__floor__",
"__ceil__",
"__enter__",
"__aenter__",
"__getnewargs_ex__",
Expand Down Expand Up @@ -182,11 +179,13 @@
"__cmp__",
"__matmul__",
"__rmatmul__",
"__imatmul__",
"__div__",
),
2: ("__setattr__", "__get__", "__set__", "__setitem__", "__set_name__"),
3: ("__exit__", "__aexit__"),
(0, 1): ("__round__",),
(1, 2): ("__pow__",),
}

SPECIAL_METHODS_PARAMS = {
Expand Down