Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new check for self assigning variable #3010

Merged
merged 2 commits into from Jul 17, 2019
Merged

Add a new check for self assigning variable #3010

merged 2 commits into from Jul 17, 2019

Conversation

PCManticore
Copy link
Contributor

@PCManticore PCManticore commented Jul 17, 2019 •
edited

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Added a new check, self-assigning-variable

This check is emitted when we detect that a variable is assigned to itself, which might indicate a potential bug in the code application.

Type of Changes

Type
✓ ✨ New feature

Related Issue

Closes #2930

@PCManticore
Added a new check, self-assigning-variable
a0d2af8 
This check is emitted when we detect that a variable is assigned
to itself, which might indicate a potential bug in the code application.
Close #2930
@PCManticore
Ignore from isort the tests from the root
9369a14
@PCManticore PCManticore merged commit be23898 into master Jul 17, 2019
@PCManticore PCManticore deleted the self-assigning-variable branch July 17, 2019 07:58
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.927% when pulling 9369a14 on self-assigning-variable into a636569 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.927% when pulling 9369a14 on self-assigning-variable into a636569 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.927% when pulling 9369a14 on self-assigning-variable into a636569 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.927% when pulling 9369a14 on self-assigning-variable into a636569 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protection against self-assignment
2 participants
@PCManticore @coveralls