Skip to content

Commit

Permalink
Update docs to reflect changes to logic.
Browse files Browse the repository at this point in the history
  • Loading branch information
mbyrnepr2 committed May 5, 2024
1 parent 81f16e4 commit dd0cbd1
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 38 deletions.
9 changes: 3 additions & 6 deletions doc/data/messages/s/singledispatch-method/bad.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,14 @@

class Board:
@singledispatch # [singledispatch-method]
@classmethod
def convert_position(cls, position):
def convert_position(self, position):
pass

@convert_position.register # [singledispatch-method]
@classmethod
def _(cls, position: str) -> tuple:
def _(self, position: str) -> tuple:
position_a, position_b = position.split(",")
return (int(position_a), int(position_b))

@convert_position.register # [singledispatch-method]
@classmethod
def _(cls, position: tuple) -> str:
def _(self, position: tuple) -> str:
return f"{position[0]},{position[1]}"
28 changes: 12 additions & 16 deletions doc/data/messages/s/singledispatch-method/good.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
from functools import singledispatch


class Board:
@singledispatch
@staticmethod
def convert_position(position):
pass

@convert_position.register
@staticmethod
def _(position: str) -> tuple:
position_a, position_b = position.split(",")
return (int(position_a), int(position_b))

@convert_position.register
@staticmethod
def _(position: tuple) -> str:
return f"{position[0]},{position[1]}"
@singledispatch
def convert_position(position):
print(position)

@convert_position.register
def _(position: str) -> tuple:
position_a, position_b = position.split(",")
return (int(position_a), int(position_b))

@convert_position.register
def _(position: tuple) -> str:
return f"{position[0]},{position[1]}"
28 changes: 12 additions & 16 deletions doc/data/messages/s/singledispatchmethod-function/bad.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
from functools import singledispatchmethod


class Board:
@singledispatchmethod # [singledispatchmethod-function]
@staticmethod
def convert_position(position):
pass

@convert_position.register # [singledispatchmethod-function]
@staticmethod
def _(position: str) -> tuple:
position_a, position_b = position.split(",")
return (int(position_a), int(position_b))

@convert_position.register # [singledispatchmethod-function]
@staticmethod
def _(position: tuple) -> str:
return f"{position[0]},{position[1]}"
@singledispatchmethod # [singledispatchmethod-function]
def convert_position(position):
print(position)

@convert_position.register # [singledispatchmethod-function]
def _(position: str) -> tuple:
position_a, position_b = position.split(",")
return (int(position_a), int(position_b))

@convert_position.register # [singledispatchmethod-function]
def _(position: tuple) -> str:
return f"{position[0]},{position[1]}"

0 comments on commit dd0cbd1

Please sign in to comment.