Continue looking for undefined variables in type checking guards. Close

#3127
pylint-dev · Sep 25, 2019 · c9e5494 · c9e5494
1 parent b74d248
commit c9e5494
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py
@@ -1357,7 +1357,8 @@ def _is_variable_violation(
                             defined_in_or_else = any(
                                 target.name == name for target in definition.targets
                             )
-                            break
+                            if defined_in_or_else:
+                                break
 
                     if not used_in_branch and not defined_in_or_else:
                         maybee0601 = True

diff --git a/tests/functional/u/undefined_variable.py b/tests/functional/u/undefined_variable.py
@@ -270,9 +270,12 @@ def func_should_fail(_dt: datetime):  # [used-before-assignment]
 
 if TYPE_CHECKING:
     from collections import Counter
+    from collections import OrderedDict
 else:
     Counter = object
+    OrderedDict = object
 
 
-def tick(counter: Counter, name: str) -> None:
+def tick(counter: Counter, name: str, dictionary: OrderedDict) -> None:
     counter[name] += 1
+    return dictionary