Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
6 changed files
with
81 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
tests/functional/ext/code_style/code_style_use_set_membership.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# pylint: disable=invalid-name,missing-docstring,pointless-statement,unnecessary-comprehension | ||
|
||
x = 1 | ||
var = frozenset({1, 2, 3}) | ||
|
||
x in var | ||
x in {1, 2, 3} | ||
x in (1, 2, 3) # [use-set-for-membership] | ||
x in [1, 2, 3] # [use-set-for-membership] | ||
|
||
if x in var: | ||
pass | ||
if x in {1, 2, 3}: | ||
pass | ||
if x in (1, 2, 3): # [use-set-for-membership] | ||
pass | ||
if x in [1, 2, 3]: # [use-set-for-membership] | ||
pass | ||
|
||
x in {*var} | ||
x in (*var,) # [use-set-for-membership] | ||
x in [*var] # [use-set-for-membership] | ||
|
||
42 if x in [1, 2, 3] else None # [use-set-for-membership] | ||
assert x in [1, 2, 3] # [use-set-for-membership] | ||
(x for x in var if x in [1, 2, 3]) # [use-set-for-membership] | ||
while x in [1, 2, 3]: # [use-set-for-membership] | ||
break | ||
|
||
# Stacked operators, rightmost pair is evaluated first | ||
# Doesn't make much sense in practice since `in` will only return `bool` | ||
True == x in [1, 2, 3] # [use-set-for-membership] # noqa: E712 | ||
1 >= x in [1, 2, 3] # [use-set-for-membership] # noqa: E712 |
2 changes: 2 additions & 0 deletions
2
tests/functional/ext/code_style/code_style_use_set_membership.rc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[MASTER] | ||
load-plugins=pylint.extensions.code_style |
12 changes: 12 additions & 0 deletions
12
tests/functional/ext/code_style/code_style_use_set_membership.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
use-set-for-membership:8:5::Consider using set for membership test:HIGH | ||
use-set-for-membership:9:5::Consider using set for membership test:HIGH | ||
use-set-for-membership:15:8::Consider using set for membership test:HIGH | ||
use-set-for-membership:17:8::Consider using set for membership test:HIGH | ||
use-set-for-membership:21:5::Consider using set for membership test:HIGH | ||
use-set-for-membership:22:5::Consider using set for membership test:HIGH | ||
use-set-for-membership:24:11::Consider using set for membership test:HIGH | ||
use-set-for-membership:25:12::Consider using set for membership test:HIGH | ||
use-set-for-membership:26:24::Consider using set for membership test:HIGH | ||
use-set-for-membership:27:11::Consider using set for membership test:HIGH | ||
use-set-for-membership:32:13::Consider using set for membership test:HIGH | ||
use-set-for-membership:33:10::Consider using set for membership test:HIGH |