invalid-overridden-method takes abc.abstractproperty in account

Close #3150
pylint-dev · Oct 16, 2019 · 237d110 · 237d110
1 parent 273412f
commit 237d110
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -25,6 +25,10 @@ Release date: TBA
 
   Close #3147
 
+* `invalid-overridden-method` takes `abc.abstractproperty` in account
+
+  Close #3150
+
 
 What's New in Pylint 2.4.2?
 ===========================

diff --git a/pylint/checkers/utils.py b/pylint/checkers/utils.py
@@ -706,8 +706,6 @@ def decorated_with_property(node: astroid.FunctionDef) -> bool:
     if not node.decorators:
         return False
     for decorator in node.decorators.nodes:
-        if not isinstance(decorator, astroid.Name):
-            continue
         try:
             if _is_property_decorator(decorator):
                 return True

diff --git a/tests/functional/i/invalid_overridden_method.py b/tests/functional/i/invalid_overridden_method.py
@@ -51,3 +51,10 @@ def close(self, attr):
     @close.deleter
     def close(self):
         return None
+
+
+class AbstractProperty:
+
+    @abc.abstractproperty
+    def prop(self):
+        return