Do not emit no-method-argument for functions using positional onl…

…y args. Close #3161
pylint-dev · Oct 11, 2019 · 15bae9f · 15bae9f
1 parent 3fc8c98
commit 15bae9f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -26,6 +26,10 @@ Release date: TBA
 
   Close #3175
 
+* Do not emit ``no-method-argument`` for functions using positional only args.
+
+  Close #3161
+
 
 What's New in Pylint 2.4.2?
 ===========================

diff --git a/pylint/checkers/classes.py b/pylint/checkers/classes.py
@@ -1460,7 +1460,12 @@ def _check_first_arg_for_type(self, node, metaclass=0):
         # don't care about functions with unknown argument (builtins)
         if node.args.args is None:
             return
-        first_arg = node.args.args and node.argnames()[0]
+        if node.args.args:
+            first_arg = node.argnames()[0]
+        elif node.args.posonlyargs:
+            first_arg = node.args.posonlyargs[0].name
+        else:
+            first_arg = None
         self._first_attrs.append(first_arg)
         first = self._first_attrs[-1]
         # static method
@@ -1474,7 +1479,7 @@ def _check_first_arg_for_type(self, node, metaclass=0):
                 return
             self._first_attrs[-1] = None
         # class / regular method with no args
-        elif not node.args.args:
+        elif not node.args.args and not node.args.posonlyargs:
             self.add_message("no-method-argument", node=node)
         # metaclass
         elif metaclass:

diff --git a/tests/functional/n/no_method_argument_py38.py b/tests/functional/n/no_method_argument_py38.py
@@ -0,0 +1,6 @@
+# pylint: disable=missing-docstring
+
+
+class Cls:
+    def __init__(self, obj, /):
+        self.obj = obj
diff --git a/tests/functional/n/no_method_argument_py38.rc b/tests/functional/n/no_method_argument_py38.rc
@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.8