fix(consider-interating-dictionary): fix false negatives

ChangeLog

@@ -11,6 +11,10 @@ Release date: TBA
 ..
   Put new features here and also in 'doc/whatsnew/2.12.rst'
 
+* Fix false negative ``consider-iterating-dictionary`` during membership checks
+
+  Closes #5323
+
 * Fix ``install graphiz`` message which isn't needed for puml output format.
 
 * Fix ``simplify-boolean-expression`` when condition can be inferred as False.

doc/whatsnew/2.12.rst

@@ -84,6 +84,10 @@ Extensions
 Other Changes
 =============
 
+* Fix false negative ``consider-iterating-dictionary`` during membership checks
+
+  Closes #5323
+
 * Fix ``install graphiz`` message which isn't needed for puml output format.
 
 * ``pylint`` no longer crashes when checking assignment expressions within if-statements

pylint/checkers/refactoring/recommendation_checker.py

@@ -83,21 +83,23 @@ def _check_consider_iterating_dictionary(self, node: nodes.Call) -> None:
             return
         if node.func.attrname != "keys":
             return
-        if (
-            isinstance(node.parent, (nodes.For, nodes.Comprehension))
-            or isinstance(node.parent, nodes.Compare)
-            and any(
-                op
-                for op, comparator in node.parent.ops
-                if op == "in" and comparator is node
-            )
+        inferred = utils.safe_infer(node.func)
+        if not isinstance(inferred, astroid.BoundMethod) or not isinstance(
+            inferred.bound, nodes.Dict
         ):
-            inferred = utils.safe_infer(node.func)
-            if not isinstance(inferred, astroid.BoundMethod) or not isinstance(
-                inferred.bound, nodes.Dict
-            ):
-                return
+            return
 
+        if isinstance(node.parent, (nodes.For, nodes.Comprehension)):
+            self.add_message("consider-iterating-dictionary", node=node)
+
+        while not isinstance(node.parent, (nodes.Compare, nodes.Module)):
+            node = node.parent
+
+        if isinstance(node.parent, nodes.Compare) and any(
+            op
+            for op, comparator in node.parent.ops
+            if op in ["in", "not in"] and comparator is node
+        ):
             self.add_message("consider-iterating-dictionary", node=node)
 
     def _check_use_maxsplit_arg(self, node: nodes.Call) -> None:

tests/functional/c/consider/consider_iterating_dictionary.py

@@ -66,3 +66,15 @@ def keys(self):
 VAR = 1 in {}
 VAR = 1 in dict()
 VAR = [1, 2] == {}.keys() in {False}
+
+# Additional membership checks
+# Issue #5323
+metadata = {}
+if "a" not in list(metadata.keys()): # [consider-iterating-dictionary]
+    print(1)
+if "a" not in metadata.keys(): # [consider-iterating-dictionary]
+    print(1)
+if "a" in list(metadata.keys()): # [consider-iterating-dictionary]
+    print(1)
+if "a" in metadata.keys(): # [consider-iterating-dictionary]
+    print(1)

tests/functional/c/consider/consider_iterating_dictionary.txt

@@ -16,3 +16,7 @@ consider-iterating-dictionary:40:60::Consider iterating the dictionary directly
 consider-iterating-dictionary:43:8::Consider iterating the dictionary directly instead of calling .keys():HIGH
 consider-iterating-dictionary:45:8::Consider iterating the dictionary directly instead of calling .keys():HIGH
 consider-iterating-dictionary:65:11::Consider iterating the dictionary directly instead of calling .keys():HIGH
+consider-iterating-dictionary:73:14::Consider iterating the dictionary directly instead of calling .keys():HIGH
+consider-iterating-dictionary:75:14::Consider iterating the dictionary directly instead of calling .keys():HIGH
+consider-iterating-dictionary:77:10::Consider iterating the dictionary directly instead of calling .keys():HIGH
+consider-iterating-dictionary:79:10::Consider iterating the dictionary directly instead of calling .keys():HIGH