Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ruff with tox #429

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Run ruff with tox #429

wants to merge 2 commits into from

Conversation

michael-k
Copy link
Contributor

@michael-k michael-k commented Feb 28, 2024

PR #414 switched to ruff, but forgot to add it to the commands section.

I've split the PR into 2 commits to showcase that ruff check is working. (Its output is empty if it doesn't find anything and ruff check --verbose is a bit too verbose.)

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8087147271

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 8055242581: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR. Ruff need to be ran through pre-commit because there's relevant exclusions in the pre-commit configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants