Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run the tests and also run them against Django 4.1-5.0 #428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michael-k
Copy link
Contributor

@michael-k michael-k commented Feb 28, 2024

When scripts/test.sh was introduced back in commit 55cb670, test_func.py had

if __name__=='__main__':
    testlib.unittest_main(defaultTest='suite')

Commit 38f2cf2 (PR #417) removed

if __name__ == "__main__":
    sys.exit(pytest.main(sys.argv))

The tests on the main branch pass, but as the logs show, pytest never runs. And the coverage shows 0%.


In my fork all tests for test old stuff / Django@… / Python@3.7 don't do anything after Resolving dependencies... and I've cancelled the workflow after 18 minutes. Maybe support for Python 3.7 can be dropped? It reached its EOL back in 2023-06-27. Django 3.2 LTS is the last version that supports Python 3.7 and that will reach its EOL in April 2024.

And exclude combinations of Django and Python that Django doesn't
support.
@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8086727311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+85.8%) to 85.829%

Totals Coverage Status
Change from base Build 8055242581: 85.8%
Covered Lines: 745
Relevant Lines: 868

💛 - Coveralls

@michael-k
Copy link
Contributor Author

Oh, so the tests on Python 3.7 do pass, they just need a very long time. 46 minutes vs. 1-2 minutes. I still propose to drop support for Python 3.7. pylint 3 requires Python 3.8+. Those who want to lint their code on Python 3.7 can still use the existing releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants