Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress some protected-access warnings when django-simple-history is installed. #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 12, 2023

  1. Supress some protected-access warnings when django-simple-history is …

    …installed.
    
    django-simple-hisory is a fairly popular [1] package for keeping track
    of changes in django objects. Setting the `_change_reason` property of
    an object is the officially documented way to provide a value for the
    `history_change_reason` field of historical objects [2].
    
    When django-simple-hisory is installed, protected-access warnings for
    setting `_change_reason` is most likely a false positive, and should be
    supressed.
    
    Because of inherent limitations of pylint, this may lead to some false
    negatives if `_change_reason` is used elsewhere.
    
    [1] https://pypistats.org/packages/django-simple-history
    [2] https://django-simple-history.readthedocs.io/en/latest/historical_model.html#change-reason
    m000 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    438151f View commit details
    Browse the repository at this point in the history