[pre-commit] Add and apply prettier #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
force-pushed
the
add-prettier
branch
from
8d53128
to
5f33672
Compare
|
I think that the slow install time might be a problem in the future, as I'd quite like the CI to run pre-commit to verify that if has been run at all (not everyone will have installed it locally first) and this could delay an already slow CI time. I will worry about that at a future time though for now 👍 for me |
carlio
approved these changes
Nov 4, 2023
|
It's cached on pre-commit.ci side so it's going to be a problem only locally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prettier installation in pre-commit is painfully slow, but it's a one time thing, I think the benefits are great after that.