Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI and remove deprecated python interpreter and django versions #400

Closed
wants to merge 6 commits into from

Conversation

Pierre-Sassoulas
Copy link
Member

@carlio I've been working on this on the side, it's not ready yet but do you agree with the removal of python interpreters and django versions ? I don't know what the exact issue is buy my intuition is that we have a combination of two things:

  • tox output is not easy to debug so launching things directly in the github action instead of tox could help with debug
  • There might be incompatibilities between some elements of the test matrices (django 4.2 not available in python 3.8, that kind of things), so changing to a more hard coded approach might help remove them
    What do you think ?

Refs #376

To match the LTS from django, and the EOL from python. We don't have to do
better than the django/python maintainers.
This reverts commit d674068.
carlio pushed a commit that referenced this pull request Oct 5, 2023
…move deprecated versions of python/django (#400) and start upgrading to be compatible with python 3.0+ (#405)
@carlio
Copy link
Collaborator

carlio commented Oct 6, 2023

@Pierre-Sassoulas in order to avoid us working on the same thing, I plan to tackle this (and #376 and #405) this weekend.

@Pierre-Sassoulas
Copy link
Member Author

Sure, I'm not touching this branch then 😄 Don't hesitate to ping me if I can do something to help

@Pierre-Sassoulas
Copy link
Member Author

I could maybe open another MR to merge Move pylint config out of tox

@carlio carlio mentioned this pull request Oct 11, 2023
@carlio
Copy link
Collaborator

carlio commented Oct 22, 2023

@Pierre-Sassoulas I have been trying to fix the CI pipeline but I think that tox+poetry and all the different versions of python and django are not playing well together. Some combinations install the dev dependencies (pytest, specifically) and some to not.

I've spent a while trying to debug it, but I think it's to do with version conflicts and how tox decides how to install from poetry deps.

Anyway, it's a bit of a mess - see all my attempts in the list of actions!). I think I will rewrite the CI/packaging from zero and start fresh, and do that in combination with a new release removing some of the support for older dependencies.

@Pierre-Sassoulas
Copy link
Member Author

Sounds good ! Might be the perfect occasion to fully migrate to pyproject.toml. Do you want me to do it ? (I have a commit ready moving pylint out of tox). Also I don't need a deep understanding of pylint-django to do that.

@carlio
Copy link
Collaborator

carlio commented Oct 22, 2023

@Pierre-Sassoulas sure, although I am thinking that moving back to setuptools/setup.py for packaging might solve a lot of problems. Having all the config in the pyproject.toml makes sense in either case.

@carlio
Copy link
Collaborator

carlio commented Oct 29, 2023

@Pierre-Sassoulas I finally closed #376 and the CI works now, so feel free to move ahead with the changes you wanted to make.

It's not completely cleanly fixed (there's a TODO in the test.sh) but at least for now it works.

@Pierre-Sassoulas
Copy link
Member Author

Wow, amazing ! I opened #412, so I'm closing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants